[FX] Fix submodule naming for subgraph split #47869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
scottxu0730
approved these changes
Nov 12, 2020
Submodules copied into a partition were using only the last atom in the qualified name, which caused problems when different Modules with the same last atom are put into the same Partition. Use the full qualname with underscores instead Differential Revision: [D24925283](https://our.internmc.facebook.com/intern/diff/D24925283) [ghstack-poisoned]
jamesr66a
pushed a commit
that referenced
this pull request
Nov 12, 2020
ghstack-source-id: bb40fbcbe0965f35544eb0d6fb1221cb6e13eb14 Pull Request resolved: #47869
💊 CI failures summary and remediationsAs of commit 85ddd4b (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
|
@jamesr66a merged this pull request in 9734c04. |
tugsbayasgalan
pushed a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
Nov 16, 2020
Summary: Pull Request resolved: pytorch#47869 Test Plan: Imported from OSS Reviewed By: scottxu0730 Differential Revision: D24925283 Pulled By: jamesr66a fbshipit-source-id: a33bff20667405a3bbfc81e1e640c2649c0db03b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Submodules copied into a partition were using only the last atom in the qualified name, which caused problems when different Modules with the same last atom are put into the same Partition. Use the full qualname with underscores instead
Differential Revision: D24925283