Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Blocking Wait if both Blocking Wait and Async Error Handling Are Set #47926

Closed
wants to merge 1 commit into from
Closed

Use Blocking Wait if both Blocking Wait and Async Error Handling Are Set #47926

wants to merge 1 commit into from

Commits on Nov 13, 2020

  1. Use Blocking Wait if both Blocking Wait and Async Error Handling Are Set 

    Given that we're soon enabling async error handling in PET, we should make the behavior explicit when users have set NCCL_BLOCKING_WAIT in their own code while also using PET. This PR essentially gives blocking wait precedence (for now). This way the blast radius of the PET change is smaller, while we continue working with blocking wait users and discussing whether moving to async error handling may be a good fit.

Differential Revision: [D24928149](https://our.internmc.facebook.com/intern/diff/D24928149/)

[ghstack-poisoned]
    @osalpekar
    osalpekar committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    675f47a View commit details
    Browse the repository at this point in the history