Set proper output differentiability for unique function #47930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 1e5e25e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
albanD
force-pushed
the
fix_unique_autograd
branch
from
ffc5cd7
to
1e5e25e
Compare
ngimel
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #47930 +/- ##
===========================================
+ Coverage 42.05% 81.25% +39.19%
===========================================
Files 472 1839 +1367
Lines 64824 198361 +133537
===========================================
+ Hits 27264 161180 +133916
+ Misses 37560 37181 -379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47851
Since the definitions of these functions in
native_functions.yamlhas special dispatch, we were already generating the properNotImplementedbehavior for these functions but we were wrongfully setting that gradient of all of the outputs.Added entries in
derivatives.yamlto allow us to specify which outpus are differentiable or not.