[cmake] clean up blas discovery #47940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47940 +/- ##
==========================================
+ Coverage 80.91% 81.04% +0.12%
==========================================
Files 1855 1842 -13
Lines 200241 199238 -1003
==========================================
- Hits 162023 161467 -556
+ Misses 38218 37771 -447 |
💊 CI failures summary and remediationsAs of commit 35282c3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
walterddr
force-pushed
the
cleanup_cmake_blas
branch
from
3ee4d42
to
4fee07d
Compare
There was a problem hiding this comment.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
malfet
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
walterddr
force-pushed
the
cleanup_cmake_blas
branch
from
f2ee3ba
to
35282c3
Compare
There was a problem hiding this comment.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@walterddr merged this pull request in af520d9. |
malfet
added a commit
that referenced
this pull request
Mar 3, 2021
Fix accidental regression introduced by #47940 `FIND_PACKAGE(OpenBLAS)` does not validate that discovered library can actually be used, while `check_fortran_libraries` does that Test Plan: Build PyTorch with static OpenBLAS and check that `torch.svd(torch.ones(3, 3)).S` do not raise an exception
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
Summary: Fix accidental regression introduced by #47940 `FIND_PACKAGE(OpenBLAS)` does not validate that discovered library can actually be used, while `check_fortran_libraries` does that Pull Request resolved: #53168 Test Plan: Build PyTorch with static OpenBLAS and check that `torch.svd(torch.ones(3, 3)).S` do not raise an exception Reviewed By: walterddr Differential Revision: D26772345 Pulled By: malfet fbshipit-source-id: 3e4675c176b30dfe4f0490d7d3dfe4f9a4037134
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Fix accidental regression introduced by pytorch#47940 `FIND_PACKAGE(OpenBLAS)` does not validate that discovered library can actually be used, while `check_fortran_libraries` does that Pull Request resolved: pytorch#53168 Test Plan: Build PyTorch with static OpenBLAS and check that `torch.svd(torch.ones(3, 3)).S` do not raise an exception Reviewed By: walterddr Differential Revision: D26772345 Pulled By: malfet fbshipit-source-id: 3e4675c176b30dfe4f0490d7d3dfe4f9a4037134
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Fix accidental regression introduced by pytorch#47940 `FIND_PACKAGE(OpenBLAS)` does not validate that discovered library can actually be used, while `check_fortran_libraries` does that Pull Request resolved: pytorch#53168 Test Plan: Build PyTorch with static OpenBLAS and check that `torch.svd(torch.ones(3, 3)).S` do not raise an exception Reviewed By: walterddr Differential Revision: D26772345 Pulled By: malfet fbshipit-source-id: 3e4675c176b30dfe4f0490d7d3dfe4f9a4037134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove useless variable changes in blas discovery