[JIT] Fix clang-tidy warnings in jit/runtime #47992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Nov 16, 2020
facebook-github-bot
added
cla signed
oncall: jit
SplitInfinity
pushed a commit
that referenced
this pull request
Nov 16, 2020
ghstack-source-id: 5e23046daa4f3c7caf5017ac5a4b931247d3212c Pull Request resolved: #47992
💊 CI failures summary and remediationsAs of commit 1378297 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 23 times. |
[ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Nov 16, 2020
ghstack-source-id: 5e9bd2d9da29ec55f2aeef30400acdc0ec0aeda4 Pull Request resolved: #47992
[ghstack-poisoned]
[ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Nov 16, 2020
ghstack-source-id: 1111bda90be179a1a9c68c02950029250080ca47 Pull Request resolved: #47992
gmagogsfm
approved these changes
Nov 21, 2020
| @@ -131,7 +131,7 @@ struct CaptureList { | |||
| auto tensors = val.toTensorList(); | |||
| sizes_.push_back(tensors.size()); | |||
|
|
|||
| for (const at::Tensor& tensor : tensors) { | |||
There was a problem hiding this comment.
As per clang-tidy, this is not a ref - there is an implicit conversion to Tensor here that this makes more explicit. I think it's related to the fact that tensors is a c10::List and a range based for actually gives you ListElementReference and not Tensor.
[ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Dec 1, 2020
ghstack-source-id: c463e35e9b1f8b9a2dbd5ee3fdd8d0050377b998 Pull Request resolved: #47992
|
@SplitInfinity merged this pull request in fc1153a. |
shaibagon
pushed a commit
to shaibagon/pytorch
that referenced
this pull request
Dec 3, 2020
Summary: Pull Request resolved: pytorch#47992 Test Plan: Imported from OSS Reviewed By: ZolotukhinM Differential Revision: D25258645 Pulled By: SplitInfinity fbshipit-source-id: b3e4576400c101b247e80cb4044fc04471f39a47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25258645