New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for complex input for torch.lu_solve #2 #48028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #48028 +/- ##
===========================================
+ Coverage 34.84% 81.30% +46.45%
===========================================
Files 455 1839 +1384
Lines 57654 198444 +140790
===========================================
+ Hits 20088 161335 +141247
+ Misses 37566 37109 -457 |
@IvanYashchuk sorry, I wasn't able to merge this before the thanksgiving break. Could you rebase this please when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
e56b224
to
3e66b92
Compare
putting in other location in the file. This reverts commit 6b9b3f5.
3e66b92
to
376392f
Compare
💊 CI failures summary and remediationsAs of commit 376392f (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
@zou3519 I didn't notice that you imported the pull request and applied some changes after that. It may need to be re-imported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…#48028) Summary: Relanding pytorch#46862 There was an issue with the simultaneous merge of two slightly conflicting PRs. This PR adds `torch.lu_solve` for complex inputs both on CPU and GPU. Pull Request resolved: pytorch#48028 Reviewed By: linbinyu Differential Revision: D25003700 Pulled By: zou3519 fbshipit-source-id: 24cd1babe9ccdbaa4e2ed23f08a9153d40d0f0cd
Relanding #46862
There was an issue with the simultaneous merge of two slightly conflicting PRs.
This PR adds
torch.lu_solve
for complex inputs both on CPU and GPU.