Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for complex input for torch.lu_solve #2 #48028

Closed
wants to merge 15 commits into from

Conversation

IvanYashchuk
Copy link
Collaborator

Relanding #46862
There was an issue with the simultaneous merge of two slightly conflicting PRs.

This PR adds torch.lu_solve for complex inputs both on CPU and GPU.

@IvanYashchuk IvanYashchuk added module: complex Related to complex number support in PyTorch module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul labels Nov 16, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #48028 (59a41e3) into master (b514951) will increase coverage by 46.45%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #48028       +/-   ##
===========================================
+ Coverage   34.84%   81.30%   +46.45%     
===========================================
  Files         455     1839     +1384     
  Lines       57654   198444   +140790     
===========================================
+ Hits        20088   161335   +141247     
+ Misses      37566    37109      -457     

@mruberry
Copy link
Collaborator

Looks like @zou3519's got this one. Thanks @zou3519!

@zou3519
Copy link
Contributor

zou3519 commented Nov 30, 2020

@IvanYashchuk sorry, I wasn't able to merge this before the thanksgiving break. Could you rebase this please when you get a chance?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

putting in other location in the file.

This reverts commit 6b9b3f5.
@dr-ci
Copy link

dr-ci bot commented Nov 30, 2020

💊 CI failures summary and remediations

As of commit 376392f (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@IvanYashchuk
Copy link
Collaborator Author

@zou3519 I didn't notice that you imported the pull request and applied some changes after that. It may need to be re-imported.
Recently tests for linear algebra routines were moved from test_torch.py to test_linalg.py that's why the git diff is smaller and looks a bit different. Effectively it's all the same code as it was.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in e41e780.

shaibagon pushed a commit to shaibagon/pytorch that referenced this pull request Dec 3, 2020
…#48028)

Summary:
Relanding pytorch#46862
There was an issue with the simultaneous merge of two slightly conflicting PRs.

This PR adds `torch.lu_solve` for complex inputs both on CPU and GPU.

Pull Request resolved: pytorch#48028

Reviewed By: linbinyu

Differential Revision: D25003700

Pulled By: zou3519

fbshipit-source-id: 24cd1babe9ccdbaa4e2ed23f08a9153d40d0f0cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: complex Related to complex number support in PyTorch module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants