New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quant] ReflectionPad2d #48036
[quant] ReflectionPad2d #48036
Conversation
[ghstack-poisoned]
Differential Revision: [D25000347](https://our.internmc.facebook.com/intern/diff/D25000347) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 7cc6b2e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
Differential Revision: [D25000347](https://our.internmc.facebook.com/intern/diff/D25000347) [ghstack-poisoned]
Differential Revision: [D25000347](https://our.internmc.facebook.com/intern/diff/D25000347) [ghstack-poisoned]
pad_l, pad_t); | ||
}); | ||
if (input.is_quantized()) { | ||
AT_DISPATCH_QINT_TYPES(input.scalar_type(), "qreflection_pad2d", [&] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just add a dispatch that works for both floating types and qint types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Differential Revision: [D25000347](https://our.internmc.facebook.com/intern/diff/D25000347) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/z-a-f/85/base #48036 +/- ##
====================================================
- Coverage 81.30% 81.29% -0.01%
====================================================
Files 1839 1839
Lines 198446 198452 +6
====================================================
- Hits 161337 161332 -5
- Misses 37109 37120 +11 |
Stack from ghstack:
Differential Revision: D25000347