Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qunat][graphmode][fx] Embedding/EmbeddingBag works in static quant qconfig #48062

Closed
wants to merge 6 commits into from

Commits on Nov 16, 2020

  1. [qunat][graphmode][fx] Embedding/EmbeddingBag works in static quant q…

    …config
    
    Summary:
    When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for
    them in the graph and keep the op unchanged and print a warning.
    This also aligns with eager mode behavior as well.
    
    We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well.
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:
    
    Tasks:
    
    Tags:
    
    [ghstack-poisoned]
    jerryzh168 committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    e5c8a0e View commit details
    Browse the repository at this point in the history
  2. Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…

    …tic quant qconfig"
    
    Summary:
    When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for
    them in the graph and keep the op unchanged and print a warning.
    This also aligns with eager mode behavior as well.
    
    We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well.
    
    We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now,
    we can add that later if needed.
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:
    
    Tasks:
    
    Tags:
    
    [ghstack-poisoned]
    jerryzh168 committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    e7cab34 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…

    …tic quant qconfig"
    
    Summary:
    When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for
    them in the graph and keep the op unchanged and print a warning.
    This also aligns with eager mode behavior as well.
    
    We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well.
    
    We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now,
    we can add that later if needed.
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:
    
    Tasks:
    
    Tags:
    
    Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537)
    
    [ghstack-poisoned]
    jerryzh168 committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    430b33a View commit details
    Browse the repository at this point in the history
  2. Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…

    …tic quant qconfig"
    
    Summary:
    When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for
    them in the graph and keep the op unchanged and print a warning.
    This also aligns with eager mode behavior as well.
    
    We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well.
    
    We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now,
    we can add that later if needed.
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:
    
    Tasks:
    
    Tags:
    
    Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537)
    
    [ghstack-poisoned]
    jerryzh168 committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    9197c5f View commit details
    Browse the repository at this point in the history
  3. Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…

    …tic quant qconfig"
    
    Summary:
    When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for
    them in the graph and keep the op unchanged and print a warning.
    This also aligns with eager mode behavior as well.
    
    We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well.
    
    We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now,
    we can add that later if needed.
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:
    
    Tasks:
    
    Tags:
    
    Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537)
    
    [ghstack-poisoned]
    jerryzh168 committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    d11fea5 View commit details
    Browse the repository at this point in the history
  4. Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…

    …tic quant qconfig"
    
    Summary:
    When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for
    them in the graph and keep the op unchanged and print a warning.
    This also aligns with eager mode behavior as well.
    
    We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well.
    
    We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now,
    we can add that later if needed.
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:
    
    Tasks:
    
    Tags:
    
    Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537)
    
    [ghstack-poisoned]
    jerryzh168 committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    372d06c View commit details
    Browse the repository at this point in the history