New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qunat][graphmode][fx] Embedding/EmbeddingBag works in static quant qconfig #48062
Commits on Nov 16, 2020
-
[qunat][graphmode][fx] Embedding/EmbeddingBag works in static quant q…
…config Summary: When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for them in the graph and keep the op unchanged and print a warning. This also aligns with eager mode behavior as well. We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for e5c8a0e - Browse repository at this point
Copy the full SHA e5c8a0eView commit details -
Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…
…tic quant qconfig" Summary: When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for them in the graph and keep the op unchanged and print a warning. This also aligns with eager mode behavior as well. We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well. We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now, we can add that later if needed. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for e7cab34 - Browse repository at this point
Copy the full SHA e7cab34View commit details
Commits on Nov 17, 2020
-
Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…
…tic quant qconfig" Summary: When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for them in the graph and keep the op unchanged and print a warning. This also aligns with eager mode behavior as well. We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well. We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now, we can add that later if needed. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 430b33a - Browse repository at this point
Copy the full SHA 430b33aView commit details -
Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…
…tic quant qconfig" Summary: When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for them in the graph and keep the op unchanged and print a warning. This also aligns with eager mode behavior as well. We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well. We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now, we can add that later if needed. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 9197c5f - Browse repository at this point
Copy the full SHA 9197c5fView commit details -
Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…
…tic quant qconfig" Summary: When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for them in the graph and keep the op unchanged and print a warning. This also aligns with eager mode behavior as well. We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well. We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now, we can add that later if needed. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for d11fea5 - Browse repository at this point
Copy the full SHA d11fea5View commit details -
Update on "[qunat][graphmode][fx] Embedding/EmbeddingBag works in sta…
…tic quant qconfig" Summary: When Embedding/EmbeddingBag are configured with static quant we'll skip inserting observer for them in the graph and keep the op unchanged and print a warning. This also aligns with eager mode behavior as well. We'll enforce this behavior for other ops that only supports dynamic/weight_only quant but not static quant as well. We used a global variable `DEFAULT_NOT_OBSERVED_QUANTIZE_HANDLER`, this is not exposed to user right now, we can add that later if needed. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25007537](https://our.internmc.facebook.com/intern/diff/D25007537) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 372d06c - Browse repository at this point
Copy the full SHA 372d06cView commit details