Make numpy optional dependency for torch.cuda.amp #48154
Conversation
Test Plan: Uninstall numpy and try to import torch
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit ec213a2 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet: This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
| elif isinstance(value, string_classes): | ||
| return value | ||
| elif isinstance(value, np.ndarray): | ||
| elif np is not None and isinstance(value, np.ndarray): | ||
| return value |
There was a problem hiding this comment.
nit: was wondering if we can just remove these 2 and add comments on the last default return (since it is a passthrough)?
There was a problem hiding this comment.
That wouldn't work, since numpy arrays are iterable (i.e. isinstance(np.ndarray(5), container_abcs.Iterable) returns True )
Test Plan: Uninstall
numpyand try to importingtorchDiscovered while working on #48145