[FX][EZ] Add Node.all_input_nodes #48270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jamesr66a
pushed a commit
that referenced
this pull request
Nov 19, 2020
ghstack-source-id: 4e39d5d60fabffd899cda0ceb52a3dd75c9136e2 Pull Request resolved: #48270
jamesr66a
changed the title
Codecov Report
@@ Coverage Diff @@
## gh/jamesr66a/321/base #48270 +/- ##
=========================================================
- Coverage 80.96% 80.86% -0.10%
=========================================================
Files 1844 1844
Lines 199448 199454 +6
=========================================================
- Hits 161483 161295 -188
- Misses 37965 38159 +194 |
Chillee
approved these changes
Nov 20, 2020
|
@jamesr66a merged this pull request in 998c4ca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Seems the discoverability of the pattern of using
map_argto pull out the input nodes fromargsandkwargswasn't very good, and people were doing hacks (e.g. inverting theusersrelations) to get inputNodesperNode. This addsNode.all_input_nodes, which just directly returns all theNodeinputs.Differential Revision: D25100241