Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix cholesky TF32 tests [v2] #48288

Closed
wants to merge 1 commit into from

Conversation

xwang233
Copy link
Collaborator

test_linalg.test_cholesky_cuda is failing on A100 machine.

The test_cholesky was probably introduced in #46083.
Also see #45492 for the fix [v1].

@xwang233
Copy link
Collaborator Author

cc @ptrblck

@xwang233 xwang233 changed the title Fix cholesky TF32 tests [v2] [WIP] Fix cholesky TF32 tests [v2] Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #48288 (c70c837) into master (c0723a0) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #48288      +/-   ##
==========================================
- Coverage   80.96%   80.81%   -0.16%     
==========================================
  Files        1844     1844              
  Lines      199443   199443              
==========================================
- Hits       161471   161170     -301     
- Misses      37972    38273     +301     

@ngimel
Copy link
Collaborator

ngimel commented Nov 20, 2020

tf32 settings should not affect linear algebra functions, and there are no matrix multiplies in the test itself, as far as I can see, so that should not be a problem for tolerances either. Can you please take a deeper look into what causes worse tolerance when tf32 is on, and fix that preferably? That is, tf32 setting should not affect cholesky result.

@ngimel ngimel removed their request for review May 30, 2021 23:45
@pytorchbot
Copy link
Collaborator

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants