-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.7.1] third_party: Update pybind to point to fork #48312
Conversation
Summary: There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#48117 Relates to: pybind/pybind11#2657 Full comparison for this update looks like this: pybind/pybind11@59a2ac2...seemethere:v2.6-fb Fixes pytorch#47776 Pull Request resolved: pytorch#48120 Reviewed By: gchanan Differential Revision: D25030688 Pulled By: seemethere fbshipit-source-id: 10889c813aeaa70ef1298adad5c631e6b5a39d72 (cherry picked from commit aa8aa30) Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Summary: Preserve PYBIND11 (pytorch@63ce3fb) configuration options in `torch._C._PYBIND11 (https://github.com/pytorch/pytorch/commit/63ce3fbde85672e112411ad731839e6db3c15c08)_COMPILER_TYPE` and use them when building extensions Also, use f-strings in `torch.utils.cpp_extension` "Fixes" pytorch#46367 Pull Request resolved: pytorch#46415 Reviewed By: VitalyFedyunin Differential Revision: D24605949 Pulled By: malfet fbshipit-source-id: 87340f2ed5308266a46ef8f0317316227dab9d4d (cherry picked from commit 2b6a720) Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
💊 CI failures summary and remediationsAs of commit d61df96 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
Codecov Report
@@ Coverage Diff @@
## release/1.7 #48312 +/- ##
===============================================
- Coverage 68.43% 68.43% -0.01%
===============================================
Files 406 406
Lines 52323 52331 +8
===============================================
+ Hits 35807 35811 +4
- Misses 16516 16520 +4
Continue to review full report at Codecov.
|
Cherry pick of (#48117, #46415)
Summary:
There are specific patches we need for Python 3.9 compatibilty and that
process is currently hung up on separate issues.
Let's update to a newer version of our forked pybind to grab the Python
3.9 fixes while we wait for them to be upstreamed
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Pull Request resolved: #48117
Relates to: pybind/pybind11#2657
Full comparison for this update looks like this: pybind/pybind11@59a2ac2...seemethere:v2.6-fb
Fixes #47776
Pull Request resolved: #48120
Reviewed By: gchanan
Differential Revision: D25030688
Pulled By: seemethere
fbshipit-source-id: 10889c813aeaa70ef1298adad5c631e6b5a39d72
(cherry picked from commit aa8aa30)
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Fixes #{issue number}