New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TensorExpr] Fix lowering for aten::div. #48329
Conversation
[ghstack-poisoned]
ghstack-source-id: 3f987d8819bba613b03f0abc5885fa1ffbe98be4 Pull Request resolved: #48329
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small update to make
Edit: nvm, looks good, was looking at old code in updatte suggestion
Differential Revision: [D25130750](https://our.internmc.facebook.com/intern/diff/D25130750) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 63c23be (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)Step: "Run tests" (full log | diagnosis details | 🔁 rerun)
|
Differential Revision: [D25130750](https://our.internmc.facebook.com/intern/diff/D25130750) [ghstack-poisoned]
Differential Revision: [D25130750](https://our.internmc.facebook.com/intern/diff/D25130750) [ghstack-poisoned]
Differential Revision: [D25130750](https://our.internmc.facebook.com/intern/diff/D25130750) [ghstack-poisoned]
Differential Revision: [D25130750](https://our.internmc.facebook.com/intern/diff/D25130750) [ghstack-poisoned]
@ZolotukhinM merged this pull request in b967119. |
Stack from ghstack:
Differential Revision: D25130750