Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorExpr] Fix lowering for aten::div. #48329

Closed
wants to merge 6 commits into from

Conversation

ZolotukhinM
Copy link

@ZolotukhinM ZolotukhinM commented Nov 20, 2020

Stack from ghstack:

Differential Revision: D25130750

ZolotukhinM pushed a commit that referenced this pull request Nov 20, 2020
ghstack-source-id: 3f987d8819bba613b03f0abc5885fa1ffbe98be4
Pull Request resolved: #48329
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Nov 20, 2020
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small update to make

Edit: nvm, looks good, was looking at old code in updatte suggestion

@dr-ci
Copy link

dr-ci bot commented Nov 20, 2020

💊 CI failures summary and remediations

As of commit 63c23be (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 21 07:23:37 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Nov 21 07:23:37 At: 
Nov 21 07:23:37   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 21 07:23:37   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 21 07:23:37  
Nov 21 07:23:37 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 21 07:23:37  
Nov 21 07:23:37 At: 
Nov 21 07:23:37   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 21 07:23:37   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 21 07:23:37  
Nov 21 07:23:37 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 21 07:23:37  
Nov 21 07:23:37 At: 
Nov 21 07:23:37   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 21 07:23:37   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 21 07:23:37  
Nov 21 07:23:37 ok (1.638s) 
Nov 21 07:23:39   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Nov 21 07:23:39 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Nov 21 07:23:39 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Nov 21 07:23:39 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 20 times.

@facebook-github-bot
Copy link
Contributor

@ZolotukhinM merged this pull request in b967119.

@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/383/head branch November 25, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants