Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added docs to nn.rst #48374

Closed
wants to merge 1 commit into from
Closed

added docs to nn.rst #48374

wants to merge 1 commit into from

Conversation

AishwaryaKalloli
Copy link
Contributor

@AishwaryaKalloli AishwaryaKalloli commented Nov 22, 2020 •
edited

Fixes #48198
Added following functions to a subsection "Global Hooks For Module" in containers sections of nn.rst.

  • register_module_forward_pre_hook
  • register_module_forward_hook
  • register_module_backward_hook

screenshots:
image
image
image

@facebook-github-bot
Copy link
Contributor

Hi @AishwaryaKalloli!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@AishwaryaKalloli AishwaryaKalloli mentioned this pull request Nov 22, 2020
Closed
@mruberry mruberry requested a review from albanD November 25, 2020 11:36
@mruberry mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 25, 2020
albanD
albanD approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great!
Thanks for the screenshot of the final result!

facebook-github-bot
facebook-github-bot reviewed Nov 30, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@albanD
Copy link
Collaborator

albanD commented Nov 30, 2020

Don't worry about the CI failure this is a slightly flaky infra. But I don't expect this change to break this build. It will be fine!

@AishwaryaKalloli
Copy link
Contributor Author

Great, Thanks!

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in fe80638.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc for global module hooks is not added to the docs website
5 participants
@AishwaryaKalloli @facebook-github-bot @albanD @pytorchbot @mruberry