Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type hints of "pooling.py". #48412

Closed
wants to merge 2 commits into from
Closed

Change the type hints of "pooling.py". #48412

wants to merge 2 commits into from

Conversation

Xianguang-Zhou
Copy link
Contributor

Change the type hints of "AvgPool2d" and "AvgPool3d".

Change the type hints of "AvgPool2d" and "AvgPool3d".
@facebook-github-bot
Copy link
Contributor

Hi @Xianguang-Zhou!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@dr-ci
Copy link

dr-ci bot commented Nov 24, 2020

💊 CI failures summary and remediations

As of commit d82adac (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #48412 (d82adac) into master (671ee71) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #48412      +/-   ##
==========================================
- Coverage   80.95%   80.95%   -0.01%     
==========================================
  Files        1854     1854              
  Lines      199918   199918              
==========================================
- Hits       161843   161841       -2     
- Misses      38075    38077       +2     

@mruberry mruberry requested review from ezyang and removed request for apaszke November 27, 2020 06:49
@mruberry mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 27, 2020
@ezyang
Copy link
Contributor

ezyang commented Nov 30, 2020

The new hints are still slightly wrong; as the argument defaults to None you should write Optional[int] here. Still, thank you for this contribution.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Xianguang-Zhou
Copy link
Contributor Author

Xianguang-Zhou commented Dec 1, 2020

Thank you very much.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 736e896.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants