Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[numpy] torch.asin : promote integer inputs to float #48461

Conversation

kshitij12345
Copy link
Collaborator

Reference #42515

@kshitij12345 kshitij12345 removed the request for review from apaszke November 25, 2020 18:26
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Nov 25, 2020
@dr-ci
Copy link

dr-ci bot commented Nov 25, 2020

💊 CI failures summary and remediations

As of commit 42ecdf8 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #48461 (42ecdf8) into master (f7a8bf2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #48461   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files        1855     1855           
  Lines      200127   200131    +4     
=======================================
+ Hits       161954   161958    +4     
  Misses      38173    38173           

@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 26, 2020
@@ -1949,6 +1949,10 @@ def test_neg_negative(self):
self._test_neg_negative(input_uncoalesced)

def _test_asin_arcsin(self, sparse_tensor):
def is_integral(dtype):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metareview note:

While test_sparse.py required significant edits to handle this relatively simple change, the rest of the test suite just required updating a few lines of metadata. This PR highlights the importance of updating and improving test_sparse.py. cc @aocsa @pearu

@mruberry mruberry self-requested a review November 27, 2020 02:50
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Unfortunately the lint build was broken in this PR's base. I reviewed the errors and they don't seem related.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 25ab39a.

@kshitij12345 kshitij12345 mentioned this pull request Dec 1, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants