New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[numpy] torch.asin
: promote integer inputs to float
#48461
[numpy] torch.asin
: promote integer inputs to float
#48461
Conversation
💊 CI failures summary and remediationsAs of commit 42ecdf8 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Codecov Report
@@ Coverage Diff @@
## master #48461 +/- ##
=======================================
Coverage 80.92% 80.92%
=======================================
Files 1855 1855
Lines 200127 200131 +4
=======================================
+ Hits 161954 161958 +4
Misses 38173 38173 |
@@ -1949,6 +1949,10 @@ def test_neg_negative(self): | |||
self._test_neg_negative(input_uncoalesced) | |||
|
|||
def _test_asin_arcsin(self, sparse_tensor): | |||
def is_integral(dtype): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Unfortunately the lint build was broken in this PR's base. I reviewed the errors and they don't seem related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Reference #42515