Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quant][fix] Add bias once in conv_fused #48593

Closed
wants to merge 6 commits into from
Closed

[quant][fix] Add bias once in conv_fused #48593

wants to merge 6 commits into from

Commits on Nov 30, 2020

  1. [quant][fix] Add bias once in conv_fused 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    d93aa90 View commit details
    Browse the repository at this point in the history

  2. Update on "[quant][fix] Add bias once in conv_fused" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    a8dcb8c View commit details
    Browse the repository at this point in the history

  3. Update on "[quant][fix] Add bias once in conv_fused" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25222215](https://our.internmc.facebook.com/intern/diff/D25222215)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    99eeb32 View commit details
    Browse the repository at this point in the history

  4. Update on "[quant][fix] Add bias once in conv_fused" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25222215](https://our.internmc.facebook.com/intern/diff/D25222215)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    b82c772 View commit details
    Browse the repository at this point in the history

  5. Update on "[quant][fix] Add bias once in conv_fused" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25222215](https://our.internmc.facebook.com/intern/diff/D25222215)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    9f83e3f View commit details
    Browse the repository at this point in the history

  6. Update on "[quant][fix] Add bias once in conv_fused" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25222215](https://our.internmc.facebook.com/intern/diff/D25222215)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    17e2dbb View commit details
    Browse the repository at this point in the history