Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScriptModule docstring #48608

Closed
wants to merge 1 commit into from

Conversation

mariosasko
Copy link
Contributor

@mariosasko mariosasko commented Nov 30, 2020

Fixes a typo in ScriptModule's docstring and converts it to the raw format (r"""...).

Fixes #48634

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Nov 30, 2020
@mariosasko mariosasko changed the title Fix ScriptModule docstring [WIP] Fix ScriptModule docstring Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #48608 (95f2980) into master (36c87f1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #48608      +/-   ##
==========================================
- Coverage   80.92%   80.92%   -0.01%     
==========================================
  Files        1855     1855              
  Lines      200194   200194              
==========================================
- Hits       162015   162012       -3     
- Misses      38179    38182       +3     

@mariosasko mariosasko changed the title [WIP] Fix ScriptModule docstring Fix ScriptModule docstring Dec 1, 2020
@gmagogsfm gmagogsfm self-requested a review December 1, 2020 09:33
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mariosasko
Copy link
Contributor Author

@gmagogsfm Please can you merge this? Didn't know this is still open.

@gmagogsfm
Copy link
Contributor

@gmagogsfm Please can you merge this? Didn't know this is still open.

Thanks for the reminder, it fell through the crack during holidays. Will merge it.

@facebook-github-bot
Copy link
Contributor

@gmagogsfm merged this pull request in 069e68a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] ScriptModule docs are not properly generated
4 participants