[pytorch] [PR] Rename cuda kernel checks to C10 #48615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D25228727 |
💊 CI failures summary and remediationsAs of commit 0bb11d3 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 16 times. |
|
This pull request was exported from Phabricator. Differential Revision: D25228727 |
kurtisdavid
force-pushed
the
export-D25228727
branch
from
69b8e00
to
f9cacce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25228727 |
kurtisdavid
force-pushed
the
export-D25228727
branch
from
f9cacce
to
cb9cd38
Compare
kurtisdavid
force-pushed
the
export-D25228727
branch
from
cb9cd38
to
15578d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25228727 |
Summary: Pull Request resolved: pytorch#48615 Convert the macro from `TORCH_CUDA_KERNEL_LAUNCH_CHECK` to `C10_CUDA_KERNEL_LAUNCH_CHECK`, since it is now accessible through c10, not just torch. Test Plan: ``` buck build //caffe2/caffe2:caffe2_cu buck build //caffe2/aten:ATen-cu buck test //caffe2/test:kernel_launch_checks -- --print-passing-details ``` Differential Revision: D25228727 fbshipit-source-id: 67053dee48ff8bcf5bbc78199636957f9b644f47
kurtisdavid
force-pushed
the
export-D25228727
branch
from
15578d6
to
0bb11d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25228727 |
|
This pull request has been merged in b824fc4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Convert the macro from
TORCH_CUDA_KERNEL_LAUNCH_CHECKtoC10_CUDA_KERNEL_LAUNCH_CHECK, since it is now accessible through c10, not just torch.Test Plan:
Differential Revision: D25228727