[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to true

[swolchok]

Stack from ghstack:

• [PyTorch] avoid unnecessary call to empty_tensor_restride in empty() #48211 [PyTorch] avoid unnecessary call to empty_tensor_restride in empty()
• [PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to true #48625 [PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to true

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: D25232196

[dr-ci]

💊 CI failures summary and remediations

As of commit 47b2524 (more details on the Dr. CI page):

---

• 1/1 failures introduced in this PR

---

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 08 01:36:09 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future

Dec 08 01:36:09 At: 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Dec 08 01:36:09  
Dec 08 01:36:09 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Dec 08 01:36:09  
Dec 08 01:36:09 At: 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Dec 08 01:36:09  
Dec 08 01:36:09 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Dec 08 01:36:09  
Dec 08 01:36:09 At: 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Dec 08 01:36:09  
Dec 08 01:36:09 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown) 
Dec 08 01:36:10 ok (1.738s) 
Dec 08 01:36:11   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:547] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Dec 08 01:36:11 ok (1.736s) 
Dec 08 01:36:13   test_return_local_rrefs (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:547] RPC agent for worker3 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown) 

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 63 times.

[ngimel]

Thanks for the fix

[facebook-github-bot]

This pull request has been merged in a20d451.