Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] repr(torch.device) #48655

Closed
wants to merge 3 commits into from
Closed

[fix] repr(torch.device) #48655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e5f62d
fix broken repr
kshitij12345 Dec 1, 2020
535c782
add relevant test
kshitij12345 Dec 1, 2020
1025f92
Merge branch 'master' into fix/device/repr
kshitij12345 Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/test_torch.py
View file
Open in desktop
Expand Up @@ -367,6 +367,17 @@ def test_device(self):
device_hash_set.add(hash(torch.device(device)))
self.assertEqual(len(device_set), len(device_hash_set))

def get_expected_device_repr(device):
if device.index is not None:
return "device(type='{type}', index={index})".format(
type=device.type, index=device.index)

return "device(type='{type}')".format(type=device.type)

for device in device_set:
dev = torch.device(device)
self.assertEqual(repr(dev), get_expected_device_repr(dev))

def test_to(self):
def test_copy_behavior(t, non_blocking=False):
self.assertIs(t, t.to(t, non_blocking=non_blocking))
Expand Down
5 changes: 4 additions & 1 deletion torch/csrc/Device.cpp
View file
Open in desktop
Expand Up @@ -30,7 +30,10 @@ PyObject *THPDevice_repr(THPDevice *self)
std::ostringstream oss;
oss << "device(type=\'" << self->device.type() << "\'";
if (self->device.has_index()) {
oss << ", index=" << self->device.index();
// `self->device.index()` returns uint8_t which is treated as ascii while printing,
// hence casting it to uint16_t.
// https://stackoverflow.com/questions/19562103/uint8-t-cant-be-printed-with-cout
oss << ", index=" << static_cast<uint16_t>(self->device.index());
}
oss << ")";
return THPUtils_packString(oss.str().c_str());
Expand Down