Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert D25199264: Enable callgrind collection for C++ snippets" #48720

Closed
wants to merge 2 commits into from

Conversation

robieta
Copy link

@robieta robieta commented Dec 2, 2020

Stack from ghstack:

This reverts commit 6646ff1.

Differential Revision: D25273994

@robieta
Copy link
Author

robieta commented Dec 2, 2020

Fixes GPU failures by adding timer=timeit.default_timer to C++ tests.

@mruberry
Copy link
Collaborator

mruberry commented Dec 2, 2020

Name your branch "ci-all/..." to run the failing test build in the github ci. Or push this commit to a new branch with that name.

…C++ snippets""

This reverts commit 6646ff1.

Differential Revision: [D25273994](https://our.internmc.facebook.com/intern/diff/D25273994)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Dec 2, 2020
This reverts commit 6646ff1.

ghstack-source-id: c5aca066141472a97b11a9fd7b790d4b74c82d6f
Pull Request resolved: #48720
@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 022c929.

shaibagon pushed a commit to shaibagon/pytorch that referenced this pull request Dec 3, 2020
…s" (pytorch#48720)

Summary:
Pull Request resolved: pytorch#48720

This reverts commit 6646ff1.

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D25273994

Pulled By: malfet

fbshipit-source-id: 61743176dc650136622e1b8f2384bbfbd7a46294
@facebook-github-bot facebook-github-bot deleted the gh/robieta/6/head branch December 6, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants