Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gradient Compression] Add an index field to GradBucket for PowerSGD #48757

Closed
wants to merge 6 commits into from

Commits on Dec 3, 2020

  1. [Gradient Compression] Add an index field to GradBucket for PowerSGD

    Add an index field to GradBucekt, so error_dict is keyed by this index instead of the hashcode of input tensor.
    
    Howevever, sometimes the buckets can be rebuilt in the forward pass. In this case, the shape of the bucket with the same index will not be consistent with the one in the previous iteration, and hence the error tensor will be re--initialized as a zero tensor of the new shape.
    
    Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
    
    Differential Revision: [D25288496](https://our.internmc.facebook.com/intern/diff/D25288496/)
    
    [ghstack-poisoned]
    wayi committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    f5cb18b View commit details
    Browse the repository at this point in the history
  2. Update on "[Gradient Compression] Add an index field to GradBucket fo…

    …r PowerSGD"
    
    Add an index field to GradBucekt, so error_dict is keyed by this index instead of the hashcode of input tensor.
    
    Howevever, sometimes the buckets can be rebuilt in the forward pass. In this case, the shape of the bucket with the same index will not be consistent with the one in the previous iteration, and hence the error tensor will be re--initialized as a zero tensor of the new shape.
    
    Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
    
    Differential Revision: [D25288496](https://our.internmc.facebook.com/intern/diff/D25288496/)
    
    [ghstack-poisoned]
    wayi committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    d1ae9af View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Update on "[Gradient Compression] Add an index field to GradBucket fo…

    …r PowerSGD"
    
    Add an index field to GradBucekt, so error_dict is keyed by this index instead of the hashcode of input tensor.
    
    Howevever, sometimes the buckets can be rebuilt in the forward pass. In this case, the shape of the bucket with the same index will not be consistent with the one in the previous iteration, and hence the error tensor will be re--initialized as a zero tensor of the new shape.
    
    Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
    
    Differential Revision: [D25288496](https://our.internmc.facebook.com/intern/diff/D25288496/)
    
    [ghstack-poisoned]
    wayi committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    ee4f2a8 View commit details
    Browse the repository at this point in the history
  2. Update on "[Gradient Compression] Add an index field to GradBucket fo…

    …r PowerSGD"
    
    Add an index field to GradBucekt, so error_dict is keyed by this index instead of the hashcode of input tensor.
    
    Howevever, sometimes the buckets can be rebuilt in the forward pass. In this case, the shape of the bucket with the same index will not be consistent with the one in the previous iteration, and hence the error tensor will be re--initialized as a zero tensor of the new shape.
    
    Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
    
    Differential Revision: [D25288496](https://our.internmc.facebook.com/intern/diff/D25288496/)
    
    [ghstack-poisoned]
    wayi committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    de1a339 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. Update on "[Gradient Compression] Add an index field to GradBucket fo…

    …r PowerSGD"
    
    Add an index field to GradBucekt, so error_dict is keyed by this index instead of the hashcode of input tensor.
    
    Howevever, sometimes the buckets can be rebuilt in the forward pass. In this case, the shape of the bucket with the same index will not be consistent with the one in the previous iteration, and hence the error tensor will be re--initialized as a zero tensor of the new shape.
    
    Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
    
    Differential Revision: [D25288496](https://our.internmc.facebook.com/intern/diff/D25288496/)
    
    [ghstack-poisoned]
    wayi committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    5cafdf8 View commit details
    Browse the repository at this point in the history
  2. Update on "[Gradient Compression] Add an index field to GradBucket fo…

    …r PowerSGD"
    
    Add an index field to GradBucekt, so error_dict is keyed by this index instead of the hashcode of input tensor.
    
    Howevever, sometimes the buckets can be rebuilt in the forward pass. In this case, the shape of the bucket with the same index will not be consistent with the one in the previous iteration, and hence the error tensor will be re--initialized as a zero tensor of the new shape.
    
    Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
    
    Differential Revision: [D25288496](https://our.internmc.facebook.com/intern/diff/D25288496/)
    
    [ghstack-poisoned]
    wayi committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    c05592d View commit details
    Browse the repository at this point in the history