Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve an autograd warning #48765

Closed
wants to merge 1 commit into from

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Dec 3, 2020

Fixes #48764

@dr-ci
Copy link

dr-ci bot commented Dec 3, 2020

💊 CI failures summary and remediations

As of commit 7d5e909 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #48765 (7d5e909) into master (0d39bd4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #48765   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files        1862     1862           
  Lines      200802   200802           
=======================================
+ Hits       162279   162286    +7     
+ Misses      38523    38516    -7     

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
Thanks for sending a PR!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in e7038a7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradcheck doesn't provide an index
3 participants