Improve new_group example in the context of SyncBatchNorm #48897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit ff8d56c (more details on the Dr. CI page):
🕵️ 5 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
pritamdamania87
approved these changes
Dec 9, 2020
torch/nn/modules/batchnorm.py
Outdated
| @@ -435,7 +435,13 @@ class SyncBatchNorm(_BatchNorm): | |||
| >>> m = nn.SyncBatchNorm(100) | |||
| >>> # creating process group (optional) | |||
| >>> # process_ids is a list of int identifying rank ids. | |||
| >>> process_group = torch.distributed.new_group(process_ids) | |||
| >>> process_ids = list(range(8)) | |||
There was a problem hiding this comment.
nit: maybe call these ranks instead of process_ids since it might be confused with OS pids.
There was a problem hiding this comment.
@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Lint failure is unrelated: ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements-flake8.txt' |
|
@rohan-varma merged this pull request in c0a0845. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48804
Improves some documentation/example in SyncBN docs to clearly show that each rank must call into all
new_group()calls for creating process subgroups, even if they are not going to be part of that particular subgroup.We then pick the right group, i.e. the group that the rank is part of, and pass that into the SyncBN APIs.
Doc rendering: