Make out ops c10-full (with hacky-wrapper) #48912

smessmer · 2020-12-07T00:09:11Z

Stack from ghstack:

Remove use_c10_dispatcher: full lines #49259 Remove use_c10_dispatcher: full lines
Remove generated_unboxing_wrappers and setManuallyBoxedKernel #49251 Remove generated_unboxing_wrappers and setManuallyBoxedKernel
Remove .impl_UNBOXED() and functionalities associated with it #49220 Remove .impl_UNBOXED() and functionalities associated with it
Remove codegen logic to support non-c10-full ops #49164 Remove codegen logic to support non-c10-full ops
Making ops c10-full: list of optional tensors #49138 [wip] Making ops c10-full: list of optional tensors
Making ops c10-full: ConstQuantizerPtr #49150 Making ops c10-full: ConstQuantizerPtr
Making ops c10-full: Storage arguments #49146 Making ops c10-full: Storage arguments
Making ops c10-full: optional lists #49088 Making ops c10-full: optional lists
Making ops c10 full: optional out arguments #49083 Making ops c10 full: optional out arguments
Making ops c10-full: Generator arguments #49013 Making ops c10-full: Generator arguments
Making ops c10 full: out overloads with default arguments #49012 Making ops c10 full: out overloads with default arguments
Making ops c10-full: Dimname arguments #49008 Making ops c10-full: Dimname arguments
Making ops c10-full: ops blocked by manual registrations #49007 Making ops c10-full: ops blocked by manual registrations
Making ops c10 full: ops returning multiple out arguments #49006 Making ops c10 full: ops returning multiple out arguments
Make out ops c10-full (with hacky-wrapper) #48912 Make out ops c10-full (with hacky-wrapper)

Benchmark:

Old (i.e. codegenerated unboxing wrapper + no hacky_wrapper):

<torch.utils.benchmark.utils.valgrind_wrapper.timer_interface.CallgrindStats object at 0x7f64d03ebcd0>
torch.absolute(t, out=o)
setup:
  t = torch.empty([1])
  o = torch.empty([1])

                           All          Noisy symbols removed
    Instructions:       657204                     634396
    Baseline:             4192                       3786
100 runs per measurement, 1 thread

New (i.e. templated unboxing wrapper + hacky_wrapper):

<torch.utils.benchmark.utils.valgrind_wrapper.timer_interface.CallgrindStats object at 0x7fa7de211cd0>
torch.absolute(t, out=o)
setup:
  t = torch.empty([1])
  o = torch.empty([1])

                           All          Noisy symbols removed
    Instructions:       658160                     633996
    Baseline:             4210                       3786
100 runs per measurement, 1 thread

Differential Revision: D25363335

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) ghstack-source-id: 117966179 Pull Request resolved: #48912

dr-ci · 2020-12-07T00:30:27Z

💊 CI failures summary and remediations

As of commit c3cd1d8 (more details on the Dr. CI page):

2/3 failures introduced in this PR
1/3 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_macos_10_13_py3_test (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Dec 15 19:37:11 RuntimeError: test_utils failed!

Dec 15 19:37:11 Generated XML report: test-reports/dist-gloo/TEST-TestFFI-20201215193630.xml 
Dec 15 19:37:11 Generated XML report: test-reports/dist-gloo/TEST-TestHipify-20201215193630.xml 
Dec 15 19:37:11 Generated XML report: test-reports/dist-gloo/TEST-TestHub-20201215193630.xml 
Dec 15 19:37:11 Generated XML report: test-reports/dist-gloo/TEST-TestONNXUtils-20201215193630.xml 
Dec 15 19:37:11 Generated XML report: test-reports/dist-gloo/TEST-TestStandaloneCPPJIT-20201215193630.xml 
Dec 15 19:37:11 Traceback (most recent call last): 
Dec 15 19:37:11   File "test/run_test.py", line 896, in <module> 
Dec 15 19:37:11     main() 
Dec 15 19:37:11   File "test/run_test.py", line 879, in main 
Dec 15 19:37:11     raise RuntimeError(err_message) 
Dec 15 19:37:11 RuntimeError: test_utils failed! 
Dec 15 19:37:12 + cleanup 
Dec 15 19:37:12 + retcode=1 
Dec 15 19:37:12 + set +x

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Dec 15 18:22:24 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']

Dec 15 18:22:23 AtenXlaType function missed override: Tensor& bitwise_or_out(Tensor& out, const Tensor& self, Scalar other); // bitwise_or_out(Tensor,Tensor,Scalar)->Tensor 
Dec 15 18:22:23 AtenXlaType function missed override: Tensor& bitwise_xor_out(Tensor& out, const Tensor& self, Scalar other); // bitwise_xor_out(Tensor,Tensor,Scalar)->Tensor 
Dec 15 18:22:23 AtenXlaType function missed override: Tensor& eye_out(Tensor& out, int64_t n); // eye_out(Tensor,int64_t)->Tensor 
Dec 15 18:22:23 AtenXlaType function missed override: Tensor& eye_out(Tensor& out, int64_t n, int64_t m); // eye_out(Tensor,int64_t,int64_t)->Tensor 
Dec 15 18:22:23 Traceback (most recent call last): 
Dec 15 18:22:23   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1172, in <module> 
Dec 15 18:22:23     generate(args) 
Dec 15 18:22:23   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1142, in generate 
Dec 15 18:22:23     assert check_overrides(overrides, overridden) 
Dec 15 18:22:23 AssertionError 
Dec 15 18:22:24 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh'] 
Dec 15 18:22:24 Building torch_xla version: 1.6 
Dec 15 18:22:24 XLA Commit ID: fe89172b2bd1c9a1c104bd2cbe565f30e6c8e328 
Dec 15 18:22:24 PyTorch Commit ID: f406f17a822af0798cd5aedc8de30af2de5a5736 
Dec 15 18:22:24 + cleanup 
Dec 15 18:22:24 + retcode=1 
Dec 15 18:22:24 + set +x 
Dec 15 18:22:24 =================== sccache compilation log =================== 
Dec 15 18:22:24 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 15 18:22:24 Compile requests                    4562 
Dec 15 18:22:24 Compile requests executed           4268

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_windows_vs2019_py36_cuda10.1_build (1/1)

Step: "Checkout code" (full log | diagnosis details | 🔁 rerun) ❄️

Writing SSH key for checkout to id_rsa

Creating .ssh directory
Adding the following entries to known_hosts:
github.com ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==
bitbucket.org ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAubiN81eDcafrgMeLzaFPsw2kNvEcqTKl/VqLat/MaB33pZy0y3rJZtnqwR2qOOvbwKZYKiEO1O6VqNEBxKvJJelCq0dTXWT5pbO2gDXC6h6QDXCaHo6pOHGPUy+YBaGQRGuSusMEASYiWunYN0vCAI8QaXnWMXNMdFP3jHAJH0eDsoiGnLPBlBp4TNm6rYI74nMzgz3B9IikW4WVK+dc8KZJZWYjAuORU3jc1c/NPskD2ASinf8v3xnfXeukU0sJ5N6m5E8VLjObPEO+mN2t/FZTMZLiFqPWc/ALSqnMnnhwrNi2rbfg/rd/IpL8Le3pSBne8+seeFVBoGqzHM9yXw==

Writing SSH key for checkout to id_rsa

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 110 times.

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Pull Request resolved: #48912 ghstack-source-id: 118059483 Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/)

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Pull Request resolved: #48912 ghstack-source-id: 118068089 Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/)

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

smessmer · 2020-12-11T09:49:21Z

Added a benchmark to the PR description

Benchmark: --- Old (i.e. codegenerated unboxing wrapper + no hacky_wrapper): ``` <torch.utils.benchmark.utils.valgrind_wrapper.timer_interface.CallgrindStats object at 0x7f64d03ebcd0> torch.absolute(t, out=o) setup: t = torch.empty([1]) o = torch.empty([1]) All Noisy symbols removed Instructions: 657204 634396 Baseline: 4192 3786 100 runs per measurement, 1 thread ``` New (i.e. templated unboxing wrapper + hacky_wrapper): ``` <torch.utils.benchmark.utils.valgrind_wrapper.timer_interface.CallgrindStats object at 0x7fa7de211cd0> torch.absolute(t, out=o) setup: t = torch.empty([1]) o = torch.empty([1]) All Noisy symbols removed Instructions: 658160 633996 Baseline: 4210 3786 100 runs per measurement, 1 thread ``` Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

facebook-github-bot · 2020-12-15T21:15:37Z

This pull request has been merged in 40a02e2.

Make out ops c10-full (with hacky-wrapper)

9854c8d

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

facebook-github-bot added the cla signed label Dec 7, 2020

smessmer added a commit that referenced this pull request Dec 7, 2020

Make out ops c10-full (with hacky-wrapper)

aaaef3a

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) ghstack-source-id: 117966179 Pull Request resolved: #48912

smessmer requested review from ezyang and bhosmer December 7, 2020 00:14

Update on "Make out ops c10-full (with hacky-wrapper)"

edd93e6

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

smessmer added a commit that referenced this pull request Dec 8, 2020

Make out ops c10-full (with hacky-wrapper)

e894a45

Pull Request resolved: #48912 ghstack-source-id: 118059483 Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/)

Update on "Make out ops c10-full (with hacky-wrapper)"

2183db3

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

b84fcb4

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

bcc1b7e

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

smessmer added a commit that referenced this pull request Dec 8, 2020

Make out ops c10-full (with hacky-wrapper)

d1e5737

Pull Request resolved: #48912 ghstack-source-id: 118068089 Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/)

Update on "Make out ops c10-full (with hacky-wrapper)"

7c55231

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

ezyang approved these changes Dec 8, 2020

View reviewed changes

Update on "Make out ops c10-full (with hacky-wrapper)"

0df4c00

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

bhosmer approved these changes Dec 9, 2020

View reviewed changes

Update on "Make out ops c10-full (with hacky-wrapper)"

124b5f1

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 9, 2020

Making ops c10-full: optional lists #49088

Closed

smessmer added 3 commits December 9, 2020 19:03

Update on "Make out ops c10-full (with hacky-wrapper)"

133b4db

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

837a46a

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

54ee228

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 10, 2020

Making ops c10-full: list of optional tensors #49138

Closed

Update on "Make out ops c10-full (with hacky-wrapper)"

3a2f0e1

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

This was referenced Dec 10, 2020

Making ops c10-full: Storage arguments #49146

Closed

Making ops c10-full: ConstQuantizerPtr #49150

Closed

smessmer added 2 commits December 9, 2020 23:17

Update on "Make out ops c10-full (with hacky-wrapper)"

8115a44

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

c112135

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 10, 2020

Remove codegen logic to support non-c10-full ops #49164

Closed

smessmer added 4 commits December 10, 2020 11:18

Update on "Make out ops c10-full (with hacky-wrapper)"

ef3a52a

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

e840ca8

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

08f3f06

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

Update on "Make out ops c10-full (with hacky-wrapper)"

198bbd1

Differential Revision: [D25363335](https://our.internmc.facebook.com/intern/diff/D25363335/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 11, 2020

Remove .impl_UNBOXED() and functionalities associated with it #49220

Closed

smessmer added 3 commits December 11, 2020 03:54

This was referenced Dec 11, 2020

Remove generated_unboxing_wrappers and setManuallyBoxedKernel #49251

Closed

Remove use_c10_dispatcher: full lines #49259

Closed

smessmer added 2 commits December 12, 2020 02:23

facebook-github-bot closed this in 40a02e2 Dec 15, 2020

facebook-github-bot added the Merged label Dec 15, 2020

facebook-github-bot deleted the gh/smessmer/272/head branch December 19, 2020 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make out ops c10-full (with hacky-wrapper) #48912

Make out ops c10-full (with hacky-wrapper) #48912

smessmer commented Dec 7, 2020 •

edited

dr-ci bot commented Dec 7, 2020 •

edited

smessmer commented Dec 11, 2020

facebook-github-bot commented Dec 15, 2020

Make out ops c10-full (with hacky-wrapper) #48912

Make out ops c10-full (with hacky-wrapper) #48912

Conversation

smessmer commented Dec 7, 2020 • edited

Benchmark:

dr-ci bot commented Dec 7, 2020 • edited

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_macos_10_13_py3_test (1/2)

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

❄️ 1 failure tentatively classified as flaky

pytorch_windows_vs2019_py36_cuda10.1_build (1/1)

smessmer commented Dec 11, 2020

facebook-github-bot commented Dec 15, 2020

smessmer commented Dec 7, 2020 •

edited

dr-ci bot commented Dec 7, 2020 •

edited