New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treat Parameter the same way as Tensor #48963
Closed
Closed
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5706906
treat Parameter the same way as Tensor, and add fast path check in co…
8556408
Update on "treat Parameter the same way as Tensor, and add fast path …
1a40adb
Update on "treat Parameter the same way as Tensor, and add fast path …
a77a5c4
Update on "treat Parameter the same way as Tensor, and add fast path …
15b4f64
Update on "treat Parameter the same way as Tensor, and add fast path …
3a4538f
Update on "treat Parameter the same way as Tensor, and add fast path …
c29817e
Update on "treat Parameter the same way as Tensor"
8713e5a
Update on "treat Parameter the same way as Tensor"
091011f
Update on "treat Parameter the same way as Tensor"
1b15442
Update on "treat Parameter the same way as Tensor"
350680c
Update on "treat Parameter the same way as Tensor"
3c6b4c9
Update on "treat Parameter the same way as Tensor"
1c46733
Update on "treat Parameter the same way as Tensor"
e1cd333
Update on "treat Parameter the same way as Tensor"
030e779
Update on "treat Parameter the same way as Tensor"
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't really matter much, but out of curiosity, is this a
py::object
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's an analog from TH. (Based on some grep-ing it seems to just be handling the incref and decref.) I just cargo cult'd the other ones.