[PyTorch] Fix getCustomClassType() perf #48981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) It was copying the entire hash table every time. 2) We don't need to do a hash lookup at all. Differential Revision: [D25385543](https://our.internmc.facebook.com/intern/diff/D25385543/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25385543/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 8, 2020
1) It was copying the entire hash table every time. 2) We don't need to do a hash lookup at all. Differential Revision: [D25385543](https://our.internmc.facebook.com/intern/diff/D25385543/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25385543/)! ghstack-source-id: 118048320 Pull Request resolved: #48981
💊 CI failures summary and remediationsAs of commit 8525492 (more details on the Dr. CI page):
Extra GitHub checks: 2 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
1) It was copying the entire hash table every time. 2) We don't need to do a hash lookup at all. Differential Revision: [D25385543](https://our.internmc.facebook.com/intern/diff/D25385543/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25385543/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 8, 2020
Pull Request resolved: #48981 1) It was copying the entire hash table every time. 2) We don't need to do a hash lookup at all. ghstack-source-id: 118065080 Differential Revision: [D25385543](https://our.internmc.facebook.com/intern/diff/D25385543/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25385543/)!
Codecov Report
@@ Coverage Diff @@
## gh/swolchok/35/base #48981 +/- ##
=======================================================
- Coverage 80.74% 80.73% -0.01%
=======================================================
Files 1869 1869
Lines 201654 201647 -7
=======================================================
- Hits 162818 162796 -22
- Misses 38836 38851 +15 |
…perf" 1) It was copying the entire hash table every time. 2) We don't need to do a hash lookup at all. Differential Revision: [D25385543](https://our.internmc.facebook.com/intern/diff/D25385543/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25385543/)! [ghstack-poisoned]
…] Fix getCustomClassType() perf" 1) It was copying the entire hash table every time. 2) We don't need to do a hash lookup at all. Differential Revision: [D25385543](https://our.internmc.facebook.com/intern/diff/D25385543/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25385543/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 9, 2020
Pull Request resolved: #48981 1) It was copying the entire hash table every time. 2) We don't need to do a hash lookup at all. ghstack-source-id: 118164406 Differential Revision: [D25385543](https://our.internmc.facebook.com/intern/diff/D25385543/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25385543/)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25385543
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!