Extra sampling of record function events [resend] #49114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: resend of #48289 Test Plan: see 48289 [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
Summary: resend of #48289 Test Plan: see 48289 Differential Revision: [D25443365](https://our.internmc.facebook.com/intern/diff/D25443365) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit ebcb18b (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 15 times. |
Summary: resend of #48289 Test Plan: see 48289 benchmarking: https://gist.github.com/ilia-cher/09daa9876082af615bb35b71683bf46e python test/benchmark_utils/test_benchmark_utils.py -k test_collect_cpp_callgrind Differential Revision: [D25443365](https://our.internmc.facebook.com/intern/diff/D25443365) [ghstack-poisoned]
ilia-cher
requested review from
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
Summary: resend of #48289 Test Plan: see 48289 benchmarking: https://gist.github.com/ilia-cher/09daa9876082af615bb35b71683bf46e python test/benchmark_utils/test_benchmark_utils.py -k test_collect_cpp_callgrind Differential Revision: [D25443365](https://our.internmc.facebook.com/intern/diff/D25443365) [ghstack-poisoned]
robieta
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
resend of #48289
Test Plan:
see 48289
benchmarking: https://gist.github.com/ilia-cher/09daa9876082af615bb35b71683bf46e
python test/benchmark_utils/test_benchmark_utils.py -k test_collect_cpp_callgrind
Differential Revision: D25443365