[quant][graphmode][fx] Add support for dynamic quant for RNN and RNNCell #49126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_rnn python test/test_quantization.py TestQuantizeFxOps.test_rnn_cell Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
requested review from
supriyar,
z-a-f,
vkuzo and
raghuramank100
and removed request for
supriyar
…NN and RNNCell" Summary: Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_rnn python test/test_quantization.py TestQuantizeFxOps.test_rnn_cell Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Dec 9, 2020
Summary: Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_rnn python test/test_quantization.py TestQuantizeFxOps.test_rnn_cell Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 810a87cfb19308fa036220936e456df46c5714f5 Pull Request resolved: #49126
💊 CI failures summary and remediationsAs of commit ff4353e (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| } | ||
| model_graph = prepare_fx(model_graph, graph_qconfig_dict) | ||
| model_graph = convert_fx(model_graph) | ||
| self.assertEqual(model_eager(sample_input), model_graph(sample_input)) |
There was a problem hiding this comment.
Do we need to test for serialization here?
There was a problem hiding this comment.
this should be the same as eager mode module, I'm not very familiar, are we using state_dict?
There was a problem hiding this comment.
or are you referring to checkScriptable
There was a problem hiding this comment.
added checkScriptable here, but in general we'll do e2e test in TestQuantizeFxModels
raghuramank100
approved these changes
Dec 10, 2020
vkuzo
reviewed
Dec 10, 2020
| @@ -124,6 +124,19 @@ def get_static_quant_module_class(float_module_class, additional_static_quant_ma | |||
| " does not have a corresponding quantized module class" | |||
| return static_quant_module_class | |||
|
|
|||
| def get_dynamic_quant_module_class(float_module_class, additional_dynamic_quant_mapping=None): | |||
There was a problem hiding this comment.
would be great to add types to function I/O
There was a problem hiding this comment.
we can add it in a separate PR I think, all other functions in this file are not typed yet
There was a problem hiding this comment.
it's not blocking this PR, but would be awesome if we started adding these as we go, at least to function I/O. We don't have to wait for a file to have existing type annots to add more. This also distributes the cost of adding them to everyone, as opposed to one person.
There was a problem hiding this comment.
yeah, fully agree that we should add types as we change code. I'm saying I plan to add it in a separate PR, or are you suggesting to add the type annotations for the functions in this file in this PR?
vkuzo
reviewed
Dec 10, 2020
…NN and RNNCell" Summary: Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_rnn python test/test_quantization.py TestQuantizeFxOps.test_rnn_cell Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25449047](https://our.internmc.facebook.com/intern/diff/D25449047) [ghstack-poisoned]
|
This pull request has been merged in 882eb0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_rnn
python test/test_quantization.py TestQuantizeFxOps.test_rnn_cell
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25449047