Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting error in set_deterministic documentation #49136

Conversation

kurtamohler
Copy link
Collaborator

Fixes formatting error that was preventing a bulleted list from being displayed properly

@kurtamohler kurtamohler added the module: docs Related to our documentation, both in docs/ and docblocks label Dec 10, 2020
@kurtamohler
Copy link
Collaborator Author

The formatting issue can currently be seen about half way down this page: https://pytorch.org/docs/stable/generated/torch.set_deterministic.html?highlight=set_deterministic#torch.set_deterministic

@dr-ci
Copy link

dr-ci bot commented Dec 10, 2020

💊 CI failures summary and remediations

As of commit c61076e (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


2 failures confirmed as flaky and can be ignored:

  • pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build
  • pytorch_linux_xenial_py3_6_gcc5_4_build

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

@mruberry
Copy link
Collaborator

Looking forward to this. Unfortunately first it has to solve the riddle of the Sphinx:

Dec 10 03:41:18 looking for now-outdated files... /opt/conda/lib/python3.6/site-packages/torch/__init__.py:docstring of torch.set_deterministic:35: WARNING: Unexpected indentation.

@mruberry mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 10, 2020
@kurtamohler kurtamohler force-pushed the fix-set_deterministic-doc-format branch from cd126f0 to 017a181 Compare December 10, 2020 17:24
@kurtamohler kurtamohler force-pushed the fix-set_deterministic-doc-format branch from 017a181 to c61076e Compare December 10, 2020 17:26
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #49136 (c61076e) into master (21c04b4) will increase coverage by 6.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #49136      +/-   ##
==========================================
+ Coverage   74.23%   80.55%   +6.32%     
==========================================
  Files        1869     1873       +4     
  Lines      202003   202133     +130     
==========================================
+ Hits       149954   162838   +12884     
+ Misses      52049    39295   -12754     

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks @kurtamohler!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in fdadfb6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: docs Related to our documentation, both in docs/ and docblocks open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants