Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add torch.eig complex forward (CPU, CUDA) #49168

Closed
wants to merge 14 commits into from
Closed

Add torch.eig complex forward (CPU, CUDA) #49168

wants to merge 14 commits into from

Commits on Dec 10, 2020

  1. enable the first eig/complex test, which currently fails [ci skip]

    @antocuni
    antocuni committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    4786d9b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. prepare lapackEig to support complex types: instead of passing wr and… 

    … wi separately, we pass only w and compute the two sub-arrays later, and add a (so far unused) rwork argument
    @antocuni
    antocuni committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    3809df9 View commit details
    Browse the repository at this point in the history

  2. progress: dispatch apply_eig also to complex types, and tweak things … 

    …around until the code compiles again. Add empty implementations for lapackEig on complex types
    @antocuni
    antocuni committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    a0034e8 View commit details
    Browse the repository at this point in the history

  3. WIP: implement lapackEig<complex<float>>, and the corresponding call … 

    …to cgeev_; test_eig_basic stil fails though
    @antocuni
    antocuni committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    5b2793d View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2020

  1. make sure that the shape of eigenvals is correct in the complex case

    @antocuni
    antocuni committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    e1daece View commit details
    Browse the repository at this point in the history

  2. add support for complex128

    @antocuni
    antocuni committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    ab8ac04 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into antocuni/eig-complex

    @antocuni
    antocuni committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    c731ac0 View commit details
    Browse the repository at this point in the history

  4. start to add CUDA support: change the signature of magmaEig to match … 

    …the one used by lapackEig
    @antocuni
    antocuni committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    e909de6 View commit details
    Browse the repository at this point in the history

  5. WIP, untested: implement magmaEig for complex types

    @antocuni
    antocuni committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    07db9c6 View commit details
    Browse the repository at this point in the history

  6. add complext support for CUDA eig

    @antocuni
    antocuni committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    5080f88 View commit details
    Browse the repository at this point in the history

  7. kill the comment as the code already does what the XXX wanted. Use a … 

    …better name for real_dtype to make it clearer
    @antocuni
    antocuni committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    e1c1ebe View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. this is a much simpler way to check whether the tensor is complex

    @antocuni
    antocuni committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    7f4060d View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Merge remote-tracking branch 'upstream/master' into antocuni/eig-complex

    @antocuni
    antocuni committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    8f69e27 View commit details
    Browse the repository at this point in the history

  2. add a test to check what happens with eig on complex types

    @antocuni
    antocuni committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    01c168d View commit details
    Browse the repository at this point in the history