[reland] Support torch.distributed.irecv(src=None, ...) #49383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reland of #47137 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/) [ghstack-poisoned]
pritamdamania87
requested review from
mingzhe09088,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
pritamdamania87
pushed a commit
that referenced
this pull request
Dec 15, 2020
Reland of #47137 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/) ghstack-source-id: 118586219 Pull Request resolved: #49383
pritamdamania87
commented
Dec 15, 2020
Comment on lines
889
to
907
| # Each rank would have 2 * (world_size - 1) sends, verify that | ||
| # globally we receive the same amount on the other end. | ||
| recv_ranks_tensor = torch.cat((torch.tensor(recv_ranks), torch.tensor(irecv_ranks)), 0) | ||
| global_recv_ranks = [ | ||
| torch.empty_like(recv_ranks_tensor), | ||
| torch.empty_like(recv_ranks_tensor), | ||
| torch.empty_like(recv_ranks_tensor), | ||
| torch.empty_like(recv_ranks_tensor), | ||
| ] | ||
| dist.all_gather(global_recv_ranks, recv_ranks_tensor) | ||
| global_recv_ranks_list = [] | ||
| for tensor in global_recv_ranks: | ||
| global_recv_ranks_list += tensor.tolist() | ||
|
|
||
| from itertools import groupby | ||
| global_recv_ranks_list.sort() | ||
| frequency = [len(list(group)) for key, group in groupby(global_recv_ranks_list)] | ||
| self.assertEqual(dist.get_world_size(), len(frequency)) | ||
| self.assertEqual([2 * (dist.get_world_size() - 1)] * dist.get_world_size(), frequency) |
There was a problem hiding this comment.
The validation here has been made more robust compared to #47137, since recvAnySource can potentially recv from anywhere.
💊 CI failures summary and remediationsAs of commit ff34456 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Reland of #47137 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Dec 16, 2020
Pull Request resolved: #49383 Reland of #47137 ghstack-source-id: 118669599 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/)
osalpekar
approved these changes
Dec 16, 2020
| return pg.recv_anysource([tensor], tag) | ||
| else: | ||
| if pg is GroupMember.WORLD: | ||
| pg.recv([tensor], src, tag).wait() |
There was a problem hiding this comment.
Why do we block in this case?
There was a problem hiding this comment.
Good catch, this is a bug.
Reland of #47137 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Dec 16, 2020
Pull Request resolved: #49383 Reland of #47137 ghstack-source-id: 118686023 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/)
Reland of #47137 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Dec 16, 2020
Pull Request resolved: #49383 Reland of #47137 ghstack-source-id: 118735407 Differential Revision: [D25551910](https://our.internmc.facebook.com/intern/diff/D25551910/)
|
This pull request has been merged in db2ecef. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49383 Reland of pytorch#47137 ghstack-source-id: 118735407 Test Plan: waitforbuildbot Reviewed By: osalpekar Differential Revision: D25551910 fbshipit-source-id: 2e1f2f77e7c69204056dfe6ed178e8ad7650ab32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Reland of #47137
Differential Revision: D25551910