Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove set_quantizer_ from native_functions.yaml #49463

Closed
wants to merge 1 commit into from
Closed

Remove set_quantizer_ from native_functions.yaml #49463

wants to merge 1 commit into from

Commits on Dec 16, 2020

  1. Remove set_quantizer_ from native_functions.yaml 

    set_quantizer_ takes a ConstQuantizerPtr argument, which is neither supported by JIT nor by c10.
Also, it doesn't get dispatched (CPU and CUDA have the same implementation) and it is excluded from python bindings generation.
So there is no real reason why this needs to be in native_functions.yaml

Removing it unblocks the migration to c10-fullness since this is an op that would have been hard to migrate. See https://fb.quip.com/QRtJAin66lPN

Differential Revision: [D25587763](https://our.internmc.facebook.com/intern/diff/D25587763/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25587763/)!

[ghstack-poisoned]
    @smessmer
    smessmer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    ad23f5d View commit details
    Browse the repository at this point in the history