Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type annotations to torch.nn.modules.fold #49479

Closed
wants to merge 2 commits into from
Closed

add type annotations to torch.nn.modules.fold #49479

wants to merge 2 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator

closes gh-49478

Fixes #49478

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Dec 16, 2020
@guilhermeleobas guilhermeleobas self-assigned this Dec 16, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 16, 2020

💊 CI failures summary and remediations

As of commit fc34956 (more details on the Dr. CI page):


  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base 006cfeb from Jan 07 until Jan 08

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 8 times.

Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and one CI failure is unrelated. Thanks @guilhermeleobas

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@guilhermeleobas
Copy link
Collaborator Author

Do not merge this PR until one checks if the annotations introduce any regression. See:
#49564 (comment)

@guilhermeleobas guilhermeleobas marked this pull request as ready for review January 8, 2021 14:57
@guilhermeleobas
Copy link
Collaborator Author

This module is already covered by tests:

test/test_jit.py::TestJitGeneratedModule::test_nn_Fold
test/test_jit.py::TestJitGeneratedModule::test_nn_Fold_int_input
test/test_jit.py::TestJitGeneratedModule::test_nn_Unfold
test/test_jit.py::TestJitGeneratedModule::test_nn_Unfold_int_input
test/test_jit.py::TestJitGeneratedFunctional::test_nn_fold
test/test_jit.py::TestJitGeneratedFunctional::test_nn_unfold

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@walterddr merged this pull request in aa18d17.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
Summary:
closes pytorchgh-49478

Fixes pytorch#49478

Pull Request resolved: pytorch#49479

Reviewed By: mruberry

Differential Revision: D25723838

Pulled By: walterddr

fbshipit-source-id: 45c4cbd6f147b6dc4a5f5419c17578c49c201022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable torch.nn.modules.fold typechecks during CI
6 participants