Create subgraph rewriter

[ansley]

Stack from ghstack:

• Create subgraph rewriter #49540 Create subgraph rewriter

Differential Revision: D25869707

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit f8aa69f (more details on the Dr. CI page):

---

• 1/1 failures possibly* introduced in this PR
  • 1/1 non-CircleCI failure(s)

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 30 times.

[jamesr66a]

OK, I suggest going through the tests and making sure that they're testing pertinent parts of the algorithm. Most of them seem to end up with a no-op pattern or patterns that are untestable by comparing output values. Additionally, when i looked at the output module code, some of them seemed to have a lot of duplicate code.

I think the thing to do primarily for this PR is to try to simplify things as much as possible. I added some notes about how the replacement algorithm can be refined. Hopefully that will make things simpler and make the tests easier to write

[jamesr66a]

Looking pretty good! Just some small stuff left

[codecov]

Codecov Report

Merging #49540 (f8aa69f) into gh/ansleyadelaide/24/base (eb87686) will decrease coverage by 0.13%.
The diff coverage is 95.55%.

@@                      Coverage Diff                      @@
##           gh/ansleyadelaide/24/base   #49540      +/-   ##
=============================================================
- Coverage                      80.70%   80.56%   -0.14%     
=============================================================
  Files                           1904     1905       +1     
  Lines                         206598   206688      +90     
=============================================================
- Hits                          166741   166527     -214     
- Misses                         39857    40161     +304     

[facebook-github-bot]

@ansley merged this pull request in 4c97ef8.