[aten] embedding_bag_byte_rowwise_offsets_out #49561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 103c4e5 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 33 times. |
facebook-github-bot
added
cla signed
fb-exported
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D25620718 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D25620718 |
ajyu
force-pushed
the
export-D25620718
branch
from
41b6aac
to
8c66356
Compare
ajyu
force-pushed
the
export-D25620718
branch
from
8c66356
to
851578e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25620718 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D25620718 |
Summary: Pull Request resolved: pytorch#49561 Out variant for embedding_bag_byte_rowwise_offsets Test Plan: ```MKL_NUM_THREADS=1 OMP_NUM_THREADS=1 numactl -m 0 -C 3 ./buck-out/opt/gen/caffe2/caffe2/fb/predictor/ptvsc2_predictor_bench --scripted_model=/data/users/ansha/tmp/adindexer/merge/traced_merge_dper_fixes.pt --p t_inputs=/data/users/ansha/tmp/adindexer/merge/container_precomputation_bs1.pt --iters=30000 --warmup_iters=10000 --num_threads=1 --pred_net=/data/users/ansha/tmp/adindexer/precomputation_merge_net.pb --c2_inp uts=/data/users/ansha/tmp/adindexer/merge/c2_inputs_precomputation_bs1.pb --c2_sigrid_transforms_opt=1 --c2_use_memonger=1 --c2_apply_nomnigraph_passes --c2_weights=/data/users/ansha/tmp/adindexer/merge/c2_weig hts_precomputation.pb --pt_enable_static_runtime --pt_cleanup_activations=true --pt_enable_out_variant=true --compare_results --do_profile``` Check embedding_bag_byte_rowwise_offsets_out is called in perf Before: 0.081438 After: 0.0783725 Reviewed By: hlu1 Differential Revision: D25620718 fbshipit-source-id: af3d9eafb301c97c8b65a2eaf348183c1b62cbaf
|
This pull request was exported from Phabricator. Differential Revision: D25620718 |
Codecov Report
@@ Coverage Diff @@
## master #49561 +/- ##
==========================================
+ Coverage 80.49% 80.68% +0.18%
==========================================
Files 1902 1902
Lines 206356 206365 +9
==========================================
+ Hits 166099 166496 +397
+ Misses 40257 39869 -388 |
|
This pull request has been merged in 6eb8e83. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Out variant for embedding_bag_byte_rowwise_offsets
Test Plan: