Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update is_floating_point() docs to mention bfloat16 #49611

Closed
wants to merge 1 commit into from

Conversation

TylerADavis
Copy link
Contributor

Fixes #49610 . Explicitly mentions that is_floating_point() will return True if passed a bfloat16 tensor.

@facebook-github-bot
Copy link
Contributor

Hi @TylerADavis!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 18, 2020

💊 CI failures summary and remediations

As of commit d1502fa (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 4 times.

@TylerADavis
Copy link
Contributor Author

I've now completed the CLA

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #49611 (d1502fa) into master (4a870f6) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #49611      +/-   ##
==========================================
+ Coverage   80.43%   80.62%   +0.19%     
==========================================
  Files        1880     1880              
  Lines      204078   204078              
==========================================
+ Hits       164140   164534     +394     
+ Misses      39938    39544     -394     

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@VitalyFedyunin merged this pull request in b414123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate description for is_floating_point()
4 participants