[quant][graphmode][fx] Allow user to specify qconfig for call_method #49621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This adds support to configure qconfig for a call_method, e.g. x.chunk, this will help workaround a problem in our internal model. TODO: since call_method is also a string and we flatten the qconfig, might need to resolve namespace conflict between call_method and module_name TODO: Add scope support to set the qconfig for call_method correctly with original qconfig Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 8669a27 (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_bionic_py3_8_gcc9_coverage_test1 |
Run tests | 🔁 rerun |
| 1 job timed out: |
pytorch_linux_bionic_py3_8_gcc9_coverage_test2
🚧 1 fixed upstream failure:
These were probably caused by upstream breakages that were already fixed.
Please rebase on the viable/strict branch (expand for instructions)
If your commit is older than viable/strict, run these commands:
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
Check out the recency history of this "viable master" tracking branch.
- pytorch_windows_vs2019_py36_cuda10.1_test1 on Dec 17 from 12:59am to 12:47pm (f5b68e7 - a727bf2)
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
This comment has been revised 14 times.
vkuzo
approved these changes
Dec 19, 2020
…all_method" Summary: This adds support to configure qconfig for a call_method, e.g. x.chunk, this will help workaround a problem in our internal model. TODO: since call_method is also a string and we flatten the qconfig, might need to resolve namespace conflict between call_method and module_name TODO: Add scope support to set the qconfig for call_method correctly with original qconfig Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25651828](https://our.internmc.facebook.com/intern/diff/D25651828) [ghstack-poisoned]
…all_method" Summary: This adds support to configure qconfig for a call_method, e.g. x.chunk, this will help workaround a problem in our internal model. TODO: since call_method is also a string and we flatten the qconfig, might need to resolve namespace conflict between call_method and module_name TODO: Add scope support to set the qconfig for call_method correctly with original qconfig Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25651828](https://our.internmc.facebook.com/intern/diff/D25651828) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Dec 19, 2020
Summary: This adds support to configure qconfig for a call_method, e.g. x.chunk, this will help workaround a problem in our internal model. TODO: since call_method is also a string and we flatten the qconfig, might need to resolve namespace conflict between call_method and module_name TODO: Add scope support to set the qconfig for call_method correctly with original qconfig Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d1f9111da8fb3db58d08590195f287fcd43a5f3c Pull Request resolved: #49621
|
This pull request has been merged in 5cde23f. |
1 similar comment
|
This pull request has been merged in 5cde23f. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
…ytorch#49621) Summary: Pull Request resolved: pytorch#49621 This adds support to configure qconfig for a call_method, e.g. x.chunk, this will help workaround a problem in our internal model. TODO: since call_method is also a string and we flatten the qconfig, might need to resolve namespace conflict between call_method and module_name TODO: Add scope support to set the qconfig for call_method correctly with original qconfig Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D25651828 fbshipit-source-id: 82d66b121d37c8274fd481b6a2e9f9b54c5ca73d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This adds support to configure qconfig for a call_method, e.g. x.chunk, this will help workaround
a problem in our internal model.
TODO: since call_method is also a string and we flatten the qconfig, might need to resolve namespace conflict between
call_method and module_name
TODO: Add scope support to set the qconfig for call_method correctly with original qconfig
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25651828