New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure FindLAPACK finds the same BLAS library #49647
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 57250c8 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_xla_linux_bionic_py3_6_clang9_test (1/2)Step: "Run tests" (full log | diagnosis details | 🔁 rerun)
|
BLAS library is found by cmake/Dependencies.cmake and then LAPACK library is found by FindLAPACK.cmake which in turn calls FindBLAS.cmake. This means that we are searching for BLAS twice and they might be different things. By setting a few variables, this can be avoided.
Codecov Report
@@ Coverage Diff @@
## master #49647 +/- ##
==========================================
- Coverage 41.55% 41.54% -0.01%
==========================================
Files 503 503
Lines 68006 68006
==========================================
- Hits 28258 28255 -3
- Misses 39748 39751 +3 |
It would be good to merge this for the conda-forge build. cc @rgommers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although it misses similar checks for Atlas and Eigen.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I added support for atlas. Eigen is not supported by |
This seems ready to land. The three CI failures are all unrelated (1 a connectivity issue, 2 timeouts) |
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This reverts [suggestion](#49647 (comment)) proposed to #49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
Summary: This reverts [suggestion](#49647 (comment)) proposed to #49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12 Test Plan: automation Reviewed By: malfet Differential Revision: D34273761 fbshipit-source-id: ba510d5a8ba3fbffe61135311f83a1d8e524d3d5
This reverts [suggestion](pytorch#49647 (comment)) proposed to pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
) This reverts [suggestion](#49647 (comment)) proposed to #49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
This reverts [suggestion](pytorch/pytorch#49647 (comment)) proposed to pytorch/pytorch#49647 Which is somehow sufficient to workaround symptoms of https://github.com/pytorch/pytorch/issue/72653 I.e. before this change, `BLAS_LIBRARIES` were set to `caffe2::mkl` which is an interface library with link property set as follows: https://github.com/pytorch/pytorch/blob/59dd84cab6ede977173cd48d64abf1bcf6b2fabb/cmake/public/mkl.cmake#L10-L12
BLAS library is found by cmake/Dependencies.cmake and then
LAPACK library is found by FindLAPACK.cmake which in turn calls
FindBLAS.cmake. This means that we are searching for BLAS twice
and they might be different things. By setting a few variables,
this can be avoided.
cc @seemethere