Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in add_pr_curve docstrings. #49648

Closed
wants to merge 1 commit into from
Closed

Fix typo in add_pr_curve docstrings. #49648

wants to merge 1 commit into from

Conversation

theodumont
Copy link
Contributor

Very small PR to fix a typo.

Description

Fixed 1 typo in the documentation of torch/utils/tensorboard/writer.py (replaced "should in" by "should be in")

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 19, 2020

💊 CI failures summary and remediations

As of commit fabd4a9 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 3 times.

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #49648 (fabd4a9) into master (c0deb23) will increase coverage by 14.46%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #49648       +/-   ##
===========================================
+ Coverage   65.95%   80.41%   +14.46%     
===========================================
  Files        1721     1884      +163     
  Lines      172494   204376    +31882     
===========================================
+ Hits       113776   164359    +50583     
+ Misses      58718    40017    -18701     

Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in b1a1271.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
Summary:
Very small PR to fix a typo.

### Description
Fixed 1 typo in the documentation of `torch/utils/tensorboard/writer.py` (replaced "_should in_" by "_should be in_")

Pull Request resolved: pytorch#49648

Reviewed By: ngimel

Differential Revision: D25665831

Pulled By: mrshenli

fbshipit-source-id: a4e733515603bb9313c1267fdf2cfcc2bc2773c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants