Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type annotations to torch.nn.parallel._functions #49687

Closed
wants to merge 1 commit into from
Closed

add type annotations to torch.nn.parallel._functions #49687

wants to merge 1 commit into from

Conversation

guilhermeleobas
Copy link
Collaborator

Closes gh-49686

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Dec 21, 2020
@guilhermeleobas guilhermeleobas self-assigned this Dec 21, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 21, 2020

💊 CI failures summary and remediations

As of commit 34ad00c (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 21 19:25:27 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Dec 21 19:25:27 At:
Dec 21 19:25:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Dec 21 19:25:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Dec 21 19:25:27 
Dec 21 19:25:27 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Dec 21 19:25:27 
Dec 21 19:25:27 At:
Dec 21 19:25:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Dec 21 19:25:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Dec 21 19:25:27 
Dec 21 19:25:27 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Dec 21 19:25:27 
Dec 21 19:25:27 At:
Dec 21 19:25:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Dec 21 19:25:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Dec 21 19:25:27 
Dec 21 19:25:27 ok (1.739s)
Dec 21 19:25:28   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Dec 21 19:25:29 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Dec 21 19:25:29 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Dec 21 19:25:29 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 6 times.

@ngimel ngimel requested a review from zou3519 December 21, 2020 18:21
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 21, 2020
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @guilhermeleobas

@rgommers rgommers requested a review from malfet December 22, 2020 15:04
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 27f0dd3.

@guilhermeleobas guilhermeleobas deleted the functions branch December 24, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: typing Related to mypy type annotations open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable torch.nn.parallel._functions typechecks during CI
6 participants