Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.utils.checkpoint.checkpoint + torch.cuda.amp #49757

Closed
wants to merge 1 commit into from

Conversation

mcarilli
Copy link
Collaborator

@mcarilli mcarilli commented Dec 22, 2020

Adds a test to orphaned original PR (#40221).

Should fix #49738 #47183 #37730

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 22, 2020

💊 CI failures summary and remediations

As of commit 4a907f2 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 3 times.

@mcarilli mcarilli changed the title test passes with diffs, fails without torch.utils.checkpoint.checkpoint + torch.cuda.amp Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #49757 (4a907f2) into master (7b4a766) will increase coverage by 5.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #49757      +/-   ##
==========================================
+ Coverage   75.20%   80.56%   +5.35%     
==========================================
  Files        1886     1890       +4     
  Lines      204860   204991     +131     
==========================================
+ Hits       154073   165154   +11081     
+ Misses      50787    39837   -10950     

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in ee27104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp does not work with LayerNorm gradient checkpointing
4 participants