Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Devirtualize TensorImpl::dim() with macro #49770

Closed
wants to merge 5 commits into from
Closed

[PyTorch] Devirtualize TensorImpl::dim() with macro #49770

wants to merge 5 commits into from

Commits on Dec 23, 2020

  1. [PyTorch] Devirtualize TensorImpl::dim() with macro 

    Seems like the performance cost of making this commonly-called method virtual isn't worth having use of undefined tensors crash a bit earlier (they'll still fail to dispatch).

Differential Revision: [D25687465](https://our.internmc.facebook.com/intern/diff/D25687465/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25687465/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    0894a65 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Update on "[PyTorch] Devirtualize TensorImpl::dim() with macro" 

    Seems like the performance cost of making this commonly-called method virtual isn't worth having use of undefined tensors crash a bit earlier (they'll still fail to dispatch).

Differential Revision: [D25687465](https://our.internmc.facebook.com/intern/diff/D25687465/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25687465/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    a4f4bff View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Update on "[PyTorch] Devirtualize TensorImpl::dim() with macro" 

    Seems like the performance cost of making this commonly-called method virtual isn't worth having use of undefined tensors crash a bit earlier (they'll still fail to dispatch).

Differential Revision: [D25687465](https://our.internmc.facebook.com/intern/diff/D25687465/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25687465/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    8fff64e View commit details
    Browse the repository at this point in the history

  2. Update on "[PyTorch] Devirtualize TensorImpl::dim() with macro" 

    Seems like the performance cost of making this commonly-called method virtual isn't worth having use of undefined tensors crash a bit earlier (they'll still fail to dispatch).

Differential Revision: [D25687465](https://our.internmc.facebook.com/intern/diff/D25687465/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25687465/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    1227ea2 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Update on "[PyTorch] Devirtualize TensorImpl::dim() with macro" 

    Seems like the performance cost of making this commonly-called method virtual isn't worth having use of undefined tensors crash a bit earlier (they'll still fail to dispatch).

Differential Revision: [D25687465](https://our.internmc.facebook.com/intern/diff/D25687465/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25687465/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d7e578f View commit details
    Browse the repository at this point in the history