New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add docstring in torch.cuda.get_device_properties #49792
Conversation
💊 CI failures summary and remediationsAs of commit 0887d40 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
1 job timed out:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
I added the docstring similar to other |
Just noticed the return types are missing after the function/class name (annotated with →) on the master docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please change Arguments
to Args
.
any updates to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fixes pytorch#49737 Added docstring in `torch.cuda.get_device_properties` Added the `Returns` in `torch.cuda.get_device_name` Pull Request resolved: pytorch#49792 Reviewed By: mruberry Differential Revision: D25784046 Pulled By: ngimel fbshipit-source-id: f88da02147f92c889398957fcaf22961d3bb1062
Fixes #49737
Added docstring in
torch.cuda.get_device_properties
Added the
Returns
intorch.cuda.get_device_name