Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate put_() from TH to ATen (CPU) #49854

Closed
wants to merge 6 commits into from

Conversation

leonvol
Copy link
Contributor

@leonvol leonvol commented Dec 25, 2020

Move CPU implementation for put_() from TH to ATen. Fixes #24751

@leonvol
Copy link
Contributor Author

leonvol commented Dec 25, 2020

Does anyone have some advice, if I can take a similar approach to take_out_cpu_template() to use at::parallel_for as the main loop in the migrated function? @VitalyFedyunin

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 25, 2020

💊 CI failures summary and remediations

As of commit e6f0ad5 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@leonvol leonvol marked this pull request as draft December 25, 2020 21:02
@nikitaved
Copy link
Collaborator

Hey, @leonvol ! You can restride your input to be efficiently used with TensorIterator. That way you will parallelize over self.numel() elements, which will eliminate the need for the serial for-loop over indices. You could have a look at #50578.

@lezcano
Copy link
Collaborator

lezcano commented Feb 4, 2021

Hi @leonvol

Is this PR still active? If not, I would not mind taking over it! :)

@leonvol
Copy link
Contributor Author

leonvol commented Feb 5, 2021

Hi @lezcano , feel free to take this PR over. I am currently quite busy :)

@lezcano
Copy link
Collaborator

lezcano commented Feb 6, 2021

Thanks! I will do so in the next few days :)

@lezcano
Copy link
Collaborator

lezcano commented Apr 6, 2021

This port was done in #53356

@lezcano lezcano closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate put_ from the TH to Aten (CPU)
5 participants