Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up type annotations in torch/nn/quantized/modules #49941

Closed
wants to merge 1 commit into from
Closed

Clean up type annotations in torch/nn/quantized/modules #49941

wants to merge 1 commit into from

Conversation

r-barnes
Copy link
Contributor

Differential Revision: D25718715

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 29, 2020 •
edited

💊 CI failures summary and remediations

As of commit f498d80 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 26 times.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25718715

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25718715

@codecov
Copy link

codecov bot commented Dec 30, 2020 •
edited

Codecov Report

Merging #49941 (f498d80) into master (70734f1) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #49941      +/-   ##
==========================================
+ Coverage   80.48%   80.68%   +0.19%     
==========================================
  Files        1900     1900              
  Lines      206210   206210              
==========================================
+ Hits       165973   166374     +401     
+ Misses      40237    39836     -401

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25718715

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25718715

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25718715

@r-barnes @facebook-github-bot
Clean up type annotations in torch/nn/quantized/modules (pytorch#49941)
f498d80 
Summary: Pull Request resolved: pytorch#49941

Test Plan: Sandcastle

Reviewed By: jerryzh168

Differential Revision: D25718715

fbshipit-source-id: 4c047215eed00ac593282587bcae95b623fcad48
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25718715

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6380869.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
@r-barnes
Clean up type annotations in torch/nn/quantized/modules (pytorch#49941)
b033040 
Summary: Pull Request resolved: pytorch#49941

Test Plan: Sandcastle

Reviewed By: jerryzh168

Differential Revision: D25718715

fbshipit-source-id: bbe450d937cf7ef634e003c09146e308180d1d58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@sab-regime sab-regime sab-regime approved these changes

Assignees
No one assigned
Labels
cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-barnes @facebook-github-bot @jerryzh168 @sab-regime