Clean up type annotations in caffe2/torch/nn/modules #49957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit c9af2a5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 8 times. |
|
This pull request was exported from Phabricator. Differential Revision: D25729745 |
Codecov Report
@@ Coverage Diff @@
## master #49957 +/- ##
===========================================
+ Coverage 70.45% 80.65% +10.20%
===========================================
Files 1899 1899
Lines 206014 206014
===========================================
+ Hits 145144 166168 +21024
+ Misses 60870 39846 -21024 |
Summary: Pull Request resolved: pytorch#49957 Test Plan: Sandcastle Differential Revision: D25729745 fbshipit-source-id: b643a115f970b5a3069fbf80a111f0026b65ce2b
|
This pull request was exported from Phabricator. Differential Revision: D25729745 |
r-barnes
force-pushed
the
export-D25729745
branch
from
1bcb7b2
to
c9af2a5
Compare
|
This pull request has been merged in d80d38c. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 14, 2021
Summary: Pull Request resolved: pytorch#49957 Test Plan: Sandcastle Reviewed By: xush6528 Differential Revision: D25729745 fbshipit-source-id: 85810e2c18ca6856480bef81217da1359b63d8a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: Sandcastle
Differential Revision: D25729745