Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove FutureMessage from RPC TorchScript implementations #50005

Closed
wants to merge 5 commits into from

Conversation

mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Jan 3, 2021

Stack from ghstack:

Differential Revision: D25750663

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 3, 2021

💊 CI failures summary and remediations

As of commit 052f23a (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jan 07 00:56:51 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Jan 07 00:56:51 At:
Jan 07 00:56:51   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Jan 07 00:56:51   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Jan 07 00:56:51 
Jan 07 00:56:51 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Jan 07 00:56:51 
Jan 07 00:56:51 At:
Jan 07 00:56:51   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Jan 07 00:56:51   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Jan 07 00:56:51 
Jan 07 00:56:51 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Jan 07 00:56:51 
Jan 07 00:56:51 At:
Jan 07 00:56:51   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Jan 07 00:56:51   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Jan 07 00:56:51 
Jan 07 00:56:51 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown)
Jan 07 00:56:51 [W tensorpipe_agent.cpp:547] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)
Jan 07 00:56:51 ok (2.554s)
Jan 07 00:56:53   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:547] RPC agent for worker2 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown)
Jan 07 00:56:53 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown)

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 23 times.

mrshenli added a commit that referenced this pull request Jan 3, 2021
ghstack-source-id: 9d33a1a82123d00fe023d74b066758bde18b3262
Pull Request resolved: #50005
torch/csrc/distributed/rpc/torchscript_functions.cpp Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in b2da0b5.

@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/273/head branch January 11, 2021 15:17
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
…ytorch#50005)

Summary: Pull Request resolved: pytorch#50005

Test Plan: Imported from OSS

Reviewed By: lw

Differential Revision: D25750663

Pulled By: mrshenli

fbshipit-source-id: 6d97156b61d82aa19dd0567ca72fe04bd7b5d1e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants