Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi label margin loss #50007

Closed
wants to merge 35 commits into from
Closed

Conversation

v0dro
Copy link
Contributor

@v0dro v0dro commented Jan 3, 2021

Reopen PR for #46975

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 3, 2021

💊 CI failures summary and remediations

As of commit 76aa2ab (more details on the Dr. CI page):


  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base 838e73d on Jan 06 from 4:14pm to 8:39pm

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 10 times.

@v0dro
Copy link
Contributor Author

v0dro commented Jan 7, 2021

@ngimel I've reopened the PR for Multi label margin loss following failure for asan. Could you please review it again?

@v0dro v0dro marked this pull request as ready for review January 8, 2021 11:38
@gchanan gchanan requested a review from ngimel January 8, 2021 18:44
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 8, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@v0dro
Copy link
Contributor Author

v0dro commented Jan 13, 2021

@rgommers any update on when this can be merged?

@rgommers
Copy link
Collaborator

@rgommers any update on when this can be merged?

It's been imported, so should be relatively soon unless there's FB-internal CI failures. That said, there's a lint failure you still need to address it looks like @v0dro. Can you please do that?

@ngimel
Copy link
Collaborator

ngimel commented Jan 13, 2021

Sorry, there's an internal build failure because of non-standard include, I thought I left the comment about it but apparently I didn't. Please fix the include.
Edit: I did leave the comment on the previous PR #46975 (comment)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented Jan 15, 2021

Can you please rebase to get rid of mypy errors?

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 7f3a407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants